Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
SMoraisAnsys
reviewed
May 3, 2024
Contributor
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
I would go for ignoring by default. I assume that many people will end up facing this issue at some point and have to ignore the changelogd directory anyway.
da1910
approved these changes
May 3, 2024
da1910
left a comment
da1910
left a comment
There was a problem hiding this comment.
Fix looks OK to me, I have no strong feelings about default/not, but the implementation looks reasonable (given my comments before about storing python in workflows)
Contributor
I would also suggest to ignore it by default. |
SMoraisAnsys
approved these changes
May 3, 2024
RobPasMue
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the option to ignore md files in the towncrier fragment file directory (typically doc/changelog.d). @da1910 ran into this issue where vale flagged
codecovin the fragment file as an error. By default, the action will check the towncrier directory unlessignore-changelogdis specified.If it makes more sense to ignore the changelog.d directory by default, then we can make the default value true. Let me know what you all think.
changelog.d directory not ignored: https://github.com/ansys/openapi-common/actions/runs/8930323884/job/24530231218?pr=575
changelog.d directory ignored & other rst files in doc are not ignored: https://github.com/ansys/openapi-common/actions/runs/8930356819/job/24530286024?pr=575
Closes #477